Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DigitalOcean] add e2e tests #10575

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented Jan 13, 2021

Initial work for adding e2e tests for DO.

Tested locally and it seems to work fine after adding the below command arguments.
go run kubetest2-kops/main.go --up --cloud-provider digitalocean --cluster-name test.myclustername.com \ --env KOPS_STATE_STORE=do://***-kops-space \ --env DIGITALOCEAN_ACCESS_TOKEN=bd5f*****472dae3 \ --env S3_ENDPOINT=sfo2.digitaloceanspaces.com \ --env S3_ACCESS_KEY_ID=PPO******NSRW \ --env S3_SECRET_ACCESS_KEY=rm******oIc \ --kops-binary-path /home/kops \ --ssh-public-key ~/.ssh/id_rsa.pub \ --kubernetes-version 1.19.2

I'll separately work with @timoreimann and @rifelpet to include the necessary environment variables.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 13, 2021
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! glad to see it isn't much effort here to add support
/ok-to-test

tests/e2e/kubetest2-kops/do/zones.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2021
Co-authored-by: Peter Rifel <rifelpet@users.noreply.github.com>
@rifelpet
Copy link
Member

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@rifelpet
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit d441149 into kubernetes:master Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jan 14, 2021
@timoreimann
Copy link
Contributor

Do we have a DO test account set up with kops already?

I know there's one that Cluster API uses which is good for sharing with other CNCF projects, but wasn't sure if that has happened already (or may be happening implicitly).

@srikiz srikiz deleted the DO-Add-E2E-Tests branch January 19, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants