Give kubetest2 its own makefile #10577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/test pull-kops-e2e-kubernetes-aws-kubetest2 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rifelpet
force-pushed
the
kubetest2-tester
branch
from
115dd5c
to
18ca211
Compare
|
/test pull-kops-e2e-kubernetes-aws-kubetest2 |
Use GOOS and GOARCH for running the kops binary Also try deploying and testing against k8s 1.20.2
rifelpet
force-pushed
the
kubetest2-tester
branch
from
18ca211
to
59c312f
Compare
|
/test pull-kops-e2e-kubernetes-aws-kubetest2 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help avoid cluttering up the main Makefile even further. I'm imagining we could put all our variants, perhaps even grid combinations (k8s version + distro + networking + cloud). That should greatly simplify the periodic job definitions.
Using GOOS and GOARCH for running the kops binary
Also try deploying and testing against k8s 1.20.2.
I'm not optimistic based on previous runs but we'll see how it goes this time. I may end up reverting back to 1.19 until we can figure out whats causing the failures.