Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd: Add /etc/crictl config to enable crictl #10585

Merged
merged 1 commit into from
Jan 15, 2021
Merged

containerd: Add /etc/crictl config to enable crictl #10585

merged 1 commit into from
Jan 15, 2021

Conversation

justinsb
Copy link
Member

This configuration file means users don't have to pass the endpoint
to run crictl.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2021
@justinsb
containerd: Add /etc/crictl config to enable crictl
f9c43bb 
This configuration file means users don't have to pass the endpoint
to run crictl.
@hakman
Copy link
Member

hakman commented Jan 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2021
@hakman
Copy link
Member

hakman commented Jan 15, 2021

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 183a014 into kubernetes:master Jan 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jan 15, 2021
@hakman hakman mentioned this pull request Jan 24, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 29, 2021
@k8s-ci-robot
Merge pull request #10653 from hakman/automated-cherry-pick-of-#10585-#…
031f882 
…10651-upstream-release-1.19

Automated cherry pick of #10585: containerd: Add /etc/crictl config to enable crictl #10651: Add back support for kubenet style networking with containerd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @k8s-ci-robot @hakman @fejta-bot