Require KOPS_TERRAFORM_0_12_RENAMED, to guard against tf breakage #10602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform 0.12 broke compatability and this could result in data loss if we deleted the etcd volumes. Document the procedure to fix the tfstate, and require an env var to be passed to avoid accidental data loss.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
force-pushed
the
terraform_renamed
branch
from
4a22159
to
6d95155
Compare
hakman
force-pushed
the
terraform_renamed
branch
from
6d95155
to
31f8cbd
Compare
This was referenced Jan 19, 2021
Merged
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 21, 2021
…-upstream-release-1.18 Automated cherry pick of #10602: Require KOPS_TERRAFORM_0_12_RENAMED, to guard against tf
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 21, 2021
…-upstream-release-1.19 Automated cherry pick of #10602: Require KOPS_TERRAFORM_0_12_RENAMED, to guard against tf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform 0.12 broke compatability and this could result in data loss
if we deleted the etcd volumes. Document the procedure to fix the
tfstate, and require an env var to be passed to avoid accidental data
loss.