Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kops e2e testing docs #10652

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Update kops e2e testing docs #10652

merged 2 commits into from
Jan 27, 2021

Conversation

bmelbourne
Copy link
Contributor

What this PR does / why we need it:
Update the kops e2e testing docs to use the latest Kubernetes kubetest2 test framework.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2021
@bmelbourne
Copy link
Contributor Author

/assign @zetaab

rifelpet
rifelpet reviewed Jan 25, 2021
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks for setting this up! Many of the flags and make targets are still in flux but this is definitely a great start. We'll add support for specifying cloud provider zones, for example.

One minor nit otherwise I think we can get this merged.

/approve

docs/contributing/testing.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@bmelbourne @rifelpet
Update docs/contributing/testing.md
9604bc9 
Co-authored-by: Peter Rifel <rifelpet@users.noreply.github.com>
@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmelbourne, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f9ec7ef into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jan 27, 2021
@bmelbourne bmelbourne deleted the update-kubetest2-e2e-test-docs branch January 27, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@rifelpet rifelpet

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bmelbourne @rifelpet @k8s-ci-robot @zetaab