Set the tcp_rmem sysctl in bootstrap script #10654
Conversation
This ensures that we're using our settings for downloading nodeup itself and any assets that nodeup downloads. This is a workaround for reported problems with the initial download on some kernels otherwise. Issue kubernetes#10206
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
This looks good. Do we know if there is any kernel issue worth tracking? I suspect it won't hit older distros like Debian 9 anyway though. |
|
Seems there was some discussion around the patch and workaround, but no conclusion: |
justinsb
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Removed the WIP, based on feedback (thanks @olemarkus and @hakman ), and a similar workaround described here: #10206 (comment) The sysctls might be setting up larger windows than we should by default, but we can tackle that separately. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…-upstream-release-1.19 Automated cherry pick of #10654: Set the tcp_rmem sysctl in bootstrap script
This ensures that we're using our settings for downloading nodeup
itself and any assets that nodeup downloads. This is a workaround for
reported problems with the initial download on some kernels otherwise.
Issue #10206