Add support for cilium 1.9 #10695
Add support for cilium 1.9 #10695
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/addons
area/api
approved
|
/retest |
olemarkus
force-pushed
the
cilium-1-9
branch
2 times, most recently
from
602f4c8
to
886fbae
Compare
|
/milestone v1.20 |
| NeedsRollingUpdate: "all", | ||
| }) | ||
| } | ||
| } else if ver.Minor == 9 { |
There was a problem hiding this comment.
Previously there was a lone } else {, was this acting as a default cilium version if the api field isn't set? If so, we should probably keep the } else { here so that 1.9 is installed by default.
EDIT: I just noticed the pkg/model/components/cilium.go change above which sets a default value so perhaps my comment doesn't apply.
There was a problem hiding this comment.
The code expects that the code running prior does the right thing. Added some guards against that not being the case now.
There was a problem hiding this comment.
Was just thinking about that error handling.
| dial-timeout: | ||
| retry-timeout: | ||
| sort-buffer-len-max: | ||
| sort-buffer-drain-timeout: |
There was a problem hiding this comment.
Could you remove the trailing spaces?
There was a problem hiding this comment.
Seems pointless to me to set empty keys like that. Removed them.
olemarkus
force-pushed
the
cilium-1-9
branch
2 times, most recently
from
939dd11
to
44b34eb
Compare
Apply suggestions from code review Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>
|
/test pull-kops-e2e-cni-cilium |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
No description provided.