Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user agent to openstack api requests #10732

Merged
merged 2 commits into from
Feb 7, 2021

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Feb 4, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 4, 2021
@zetaab
Copy link
Member Author

zetaab commented Feb 4, 2021

/test pull-kops-e2e-k8s-containerd

@olemarkus
Copy link
Member

/lgtm

This can be quite useful

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@zetaab
Copy link
Member Author

zetaab commented Feb 5, 2021

@olemarkus can you check again, I just modified the names little bit. The problem that we have currently is that some kops component is calling openstack apis quite heavily. We have currently 30 kops clusters in openstack and those are making 1.2M requests in 24 hours against api (so one cluster makes 40k requests/24 hours, which is imo quite much). The problem is not csi-cinder or openstack cloud controller manager those do have own user agents. I am adding these user agents to be able to debug from where these requests are coming from. I also added uagent to etcd-manager kopeio/etcd-manager#395

currently only thing that we can see is that requests are coming from gophercloud/2.0.0

@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 016b0e5 into kubernetes:master Feb 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 7, 2021
@zetaab zetaab deleted the feature/uagent branch February 8, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants