Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use expected LaunchTemplateId in updating ASG when MixedInstancePolicy is changed #10742

Merged
merged 1 commit into from Feb 5, 2021
Merged

Use expected LaunchTemplateId in updating ASG when MixedInstancePolicy is changed #10742

merged 1 commit into from Feb 5, 2021

Conversation

h3poteto
Copy link
Contributor

@h3poteto h3poteto commented Feb 5, 2021

refs: #10718

When user changes only mixedInstancePolicy, LaunchTemplateId is not changed.
But current logic expect changes to LaunchTemplateId; therefore nil pointer dereference has occur.

In this case, it is not necessary to change LaunchTemplateId in AutoScalingGroup, so I fixed it.

I don't know the reason for this logic. If anyone knows why, please tell me.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @h3poteto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2021
@h3poteto h3poteto marked this pull request as ready for review February 5, 2021 13:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2021
@rifelpet
Copy link
Member

rifelpet commented Feb 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2021
@h3poteto
Use expected LaunchTemplateId in updating ASG when MixedInstancePolic…
37c68e2 
…y is changed

When user changes only mixedInstancePolicy, LaunchTemplateId is not changed.
So it is not necessary to change LaunchTemplateId in AutoScalingGroup.
@hakman
Copy link
Member

hakman commented Feb 5, 2021

Thanks @h3poteto!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: h3poteto, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@hakman hakman mentioned this pull request Feb 5, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit 5c50fff into kubernetes:master Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 5, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 5, 2021
@k8s-ci-robot
Merge pull request #10743 from hakman/automated-cherry-pick-of-#10742…
2e43884 
…-upstream-release-1.19

Automated cherry pick of #10742: Use expected LaunchTemplateId in updating ASG when
@rifelpet rifelpet mentioned this pull request Feb 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman left review comments

@johngmyers johngmyers Awaiting requested review from johngmyers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@h3poteto @k8s-ci-robot @rifelpet @hakman