-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always generate kops-controller certs #10758
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @rifelpet @johngmyers |
/retest |
/lgtm |
…-upstream-release-1.19 Automated cherry pick of #10758: Always generate kops-controller certs
Yes, I concur with this fix; it is consistent with our always labelling with the pki label! Thanks @hakman! |
Thanks @justinsb. I guess now all blockers for 1.19.1 are fixed? |
I think we also want to figure out the kubenet + containerd thing... I borrowed your trick and am trying to get that to pass... They all pass on GCE somehow (https://k8s-testgrid.appspot.com/google-gce#gce-containerd) I'm generally double-checking the list... we should probably also check this fix against the two reported scenarios (at least mentally run through the scenarios!) |
This is a quick simple fix, but can be easily be reverted and a better one added later.
Fixes: #10704