Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always generate kops-controller certs #10758

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 7, 2021

This is a quick simple fix, but can be easily be reverted and a better one added later.

Fixes: #10704

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2021
@hakman
Copy link
Member Author

hakman commented Feb 7, 2021

/cc @rifelpet @johngmyers

@hakman
Copy link
Member Author

hakman commented Feb 8, 2021

/retest

@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 8, 2021
…-upstream-release-1.19

Automated cherry pick of #10758: Always generate kops-controller certs
@k8s-ci-robot k8s-ci-robot merged commit 741564e into kubernetes:master Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 8, 2021
@justinsb
Copy link
Member

justinsb commented Feb 8, 2021

Yes, I concur with this fix; it is consistent with our always labelling with the pki label!

Thanks @hakman!

@hakman hakman deleted the kops-controller-certs branch February 8, 2021 15:46
@hakman
Copy link
Member Author

hakman commented Feb 8, 2021

Thanks @justinsb. I guess now all blockers for 1.19.1 are fixed?

@justinsb
Copy link
Member

justinsb commented Feb 8, 2021

I think we also want to figure out the kubenet + containerd thing... I borrowed your trick and am trying to get that to pass... They all pass on GCE somehow (https://k8s-testgrid.appspot.com/google-gce#gce-containerd)

I'm generally double-checking the list... we should probably also check this fix against the two reported scenarios (at least mentally run through the scenarios!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kops-controller enters crashloop on update to k8s 1.19.7
4 participants