Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow managed images for Azure instance groups #10797

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

NickSchleicher
Copy link
Contributor

Allows us to use our own managed images for virtual machine scale sets and not just ones that are published to the marketplace.

Related to
Be able to configure some more parameters for VM Scale Set such as Windows in #10412

Not sure if it's necessary we should check for a
/subscriptions/<subscription id>/resourceGroups/<resource group>/providers/<provider>/images/<image> format

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @NickSchleicher. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 11, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2021
@rifelpet
Copy link
Member

/ok-to-test

This looks good to me. For reference, cluster-api doesn't perform any input validation on the ID contents so I think its acceptable for kops not to either: https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/29ba7f37f1f1e2274bee24bc66ef9561dd158c73/api/v1alpha3/azureimage_validation.go

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2021
@NickSchleicher
Copy link
Contributor Author

Thanks for that reference @rifelpet was curious on the protocol for things like that, will remember in the future

@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NickSchleicher, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7d8ef74 into kubernetes:master Feb 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 13, 2021
@rifelpet rifelpet modified the milestones: v1.20, v1.21 Feb 13, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 13, 2021
…97-origin-release-1.20

Automated cherry pick of #10797: Allow managed images for Azure instance groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants