-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow managed images for Azure instance groups #10797
Conversation
Hi @NickSchleicher. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test This looks good to me. For reference, cluster-api doesn't perform any input validation on the ID contents so I think its acceptable for kops not to either: https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/29ba7f37f1f1e2274bee24bc66ef9561dd158c73/api/v1alpha3/azureimage_validation.go |
Thanks for that reference @rifelpet was curious on the protocol for things like that, will remember in the future |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NickSchleicher, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…97-origin-release-1.20 Automated cherry pick of #10797: Allow managed images for Azure instance groups
Allows us to use our own managed images for virtual machine scale sets and not just ones that are published to the marketplace.
Related to
Be able to configure some more parameters for VM Scale Set such as Windows
in #10412Not sure if it's necessary we should check for a
/subscriptions/<subscription id>/resourceGroups/<resource group>/providers/<provider>/images/<image>
format