Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add usage of subnet and routetable shared resources in azure #10900

Merged
merged 1 commit into from
Feb 23, 2021
Merged

add usage of subnet and routetable shared resources in azure #10900

merged 1 commit into from
Feb 23, 2021

Conversation

ngalantowicz
Copy link
Contributor

@ngalantowicz ngalantowicz commented Feb 22, 2021 •
edited
Loading

  • adds support tag update of virtual networks (mentioned here Remaining work for Azure support #10412)
  • adds support for shared route table and subnet resources
    • note: azure does not support subnet tagging so shared subnet is determined by sharedVPC
  • fixes infrequent panic during export kubecfg task of cluster creation due to race condition where scaleSets are being reported

@kenji-cloudnatix

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ngalantowicz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added area/api area/provider/azure Issues or PRs related to azure provider labels Feb 22, 2021
kenji-cloudnatix
kenji-cloudnatix approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@kenji-cloudnatix kenji-cloudnatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making the change!

@k8s-ci-robot
Copy link
Contributor

@kenji-cloudnatix: changing LGTM is restricted to collaborators

In response to this:

Looks good! Thanks for making the change!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman
Copy link
Member

hakman commented Feb 23, 2021

Thanks @ngalantowicz.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 23, 2021
@hakman
Copy link
Member

hakman commented Feb 23, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, kenji-cloudnatix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@hakman hakman mentioned this pull request Feb 23, 2021
Merged
@hakman
Copy link
Member

hakman commented Feb 23, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 34ac8d5 into kubernetes:master Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 23, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 23, 2021
@k8s-ci-robot
Merge pull request #10903 from hakman/automated-cherry-pick-of-#10900…
0586643 
…-upstream-release-1.20

Automated cherry pick of #10900: add usage of subnet and routetable shared resources in azure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenji-cloudnatix kenji-cloudnatix kenji-cloudnatix approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ngalantowicz @k8s-ci-robot @hakman @kenji-cloudnatix