add support for azure public loadbalancer

[collin-woodruff-t1cg]

No description provided.

[k8s-ci-robot]

Hi @collin-woodruff-t1cg. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rifelpet]

/ok-to-test

/cc @kenji-cloudnatix

Looks reasonable to me. I noticed we give the public IP address the same name as the load balancer. Can a load balancer have more than one public IP address? If so we may want to suffix the IP address name.

[k8s-ci-robot]

@rifelpet: GitHub didn't allow me to request PR reviews from the following users: kenji-cloudnatix.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/ok-to-test

/cc @kenji-cloudnatix

Looks reasonable to me. I noticed we give the public IP address the same name as the load balancer. Can a load balancer have more than one public IP address? If so we may want to suffix the IP address name.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kenji-cloudnatix]

Looks good to me too!

[k8s-ci-robot]

@kenji-cloudnatix: changing LGTM is restricted to collaborators

In response to this:

Looks good to me too!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[collin-woodruff-t1cg]

I think it is possible for the load balancer to have multiple IP addresses. How would you want me to suffix the name?

[rifelpet]

hm it would make sense to suffix the public iP name with something that would differentiate it in situations in which we'd have multiple public IPs. From my cursory search of the docs it seems one would use multiple public IPs for differentiating traffic that uses the same port and protocol. I can't imagine a need for that for our api load balancer, so perhaps keeping the name identical to the load balancer is sufficient.

https://docs.microsoft.com/en-us/azure/virtual-network/public-ip-addresses#internet-facing-load-balancers
https://docs.microsoft.com/en-us/azure/load-balancer/load-balancer-multivip-overview

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kenji-cloudnatix, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.