Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #10957: Add support for enable-cadvisor-json-endpoints with Kubelet #10969

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 3, 2021

Cherry pick of #10957 on release-1.20.

#10957: Add support for enable-cadvisor-json-endpoints with Kubelet

For details on the cherry pick process, see the cherry pick requests page.

Kubernetes 1.18 disables this by default.
For backwards compatibility with monitoring tools, it would be nice to
be able to re-enable this.

kubernetes/kubernetes#68522
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added area/api size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit e9d21cc into kubernetes:release-1.20 Mar 3, 2021
@hakman hakman deleted the automated-cherry-pick-of-#10957-upstream-release-1.20 branch March 13, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants