cluster validation - allow flapping of validation errors #11049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously with --wait if a cluster successfully validated and then a subsequent validation failed (perhaps due to a new critical pod being scheduled and not being ready) we would previously fail the `validate cluster` command immediately. This will now reset the success counter that approaches --count, allowing validation attempts to continue until we timeout from --wait. I'm hoping this fixes prow job failures like this: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/e2e-kops-grid-u1804-k18-containerd/1370875829445201920 where `kops validate cluster --count 10 --wait 15m` was invoked at `23:15:48` but exited with failure at `23:22:59`. In my opinion, `kops validate cluster --count 10 --wait 15m` should only ever exit with failure if the 15 minute timeout has been reached.
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
cncf-cla: yes
hakman
approved these changes
Mar 14, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 5, 2021
…49-origin-release-1.20 Automated cherry pick of #11049: cluster validation - allow flapping of validation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously with --wait if a cluster successfully validated and then a subsequent validation failed
(perhaps due to a new critical pod being scheduled and not being ready) we would previously fail the
validate clustercommand immediately.This will now reset the success counter that approaches --count, allowing validation attempts to continue until we timeout from --wait.
I'm hoping this fixes prow job failures like this where
kops validate cluster --count 10 --wait 15mwas invoked at23:15:48but exited with failure at23:22:59(a duration of only 7m11s). It passed validation 4 consecutive times but failed when a kube-proxy pod became pending. In that case we should just reset the counter and continue validation attempts until we timeout.In my opinion,
kops validate cluster --count 10 --wait 15mshould only ever exit with failure if the 15 minute timeout has been reached.