Have nodeup retry kops-controller bootstrapping sooner if DNS isn't setup #11101
Conversation
k8s-ci-robot
added
cncf-cla: yes
rifelpet
force-pushed
the
nodeup-kc-retry
branch
from
09a798b
to
6151995
Compare
k8s-ci-robot
added
lgtm
|
hm looks like these errors are being hit over 10 minutes after the dns record is created. Will need some additional troubleshooting |
|
Yeah, not sure what's going on there but I see the same thing. Maybe log the error and the host name we're resolving? |
| } else { | ||
| for _, ip := range ips { | ||
| if ip.String() == cloudup.PlaceholderIP { | ||
| return nil, fi.NewTryAgainLaterError("kops-controller DNS not setup yet") |
There was a problem hiding this comment.
Probably also a good idea to differentiate the two messages e.g. ("kops-controller DNS not setup yet (placeholder IP found)" vs "kops-controller DNS not setup yet (error was %v)"
There was a problem hiding this comment.
Good idea, it turns out URL.Host includes the port number which will never resolve. Updating it to URL.Hostname() seems to have shaved off a couple minutes on the kops validate cluster time in this small sample size of presubmit jobs.
|
/retest Review the full test history for this PR. Silence the bot with an |
rifelpet
force-pushed
the
nodeup-kc-retry
branch
from
6151995
to
de2ad2a
Compare
k8s-ci-robot
removed
the
lgtm
rifelpet
force-pushed
the
nodeup-kc-retry
branch
from
de2ad2a
to
639c9c4
Compare
rifelpet
force-pushed
the
nodeup-kc-retry
branch
from
639c9c4
to
763d1e2
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…101-origin-release-1.20 Automated cherry pick of #11101: Have nodeup retry kops-controller bootstrapping sooner if DNS
ref: #11050 (comment)