Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Use BDM to configure the root volume size at VNG level #11179

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Apr 6, 2021

This PR removes the setting of the obsolete rootVolumeSize field in order to resolve a validation error returned from the Spot backend:

{
  "request": {
    "id": "dedd14d9-7f56-4bee-951b-redacted",
    "url": "/ocean/aws/k8s/launchSpec",
    "method": "POST",
    "timestamp": "2021-04-06T19:33:53.885Z"
  },
  "response": {
    "status": {
      "code": 400,
      "message": "Bad Request"
    },
    "errors": [
      {
        "code": "ValidationError",
        "message": "\"rootVolumeSize\" must not exist simultaneously with [blockDeviceMappings]",
        "field": "body:launchSpec"
      }
    ]
  }
}

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/spotinst Issues or PRs related to spotinst provider label Apr 6, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2021
@hakman
Copy link
Member

hakman commented Apr 7, 2021

/approve

1 similar comment
@hakman
Copy link
Member

hakman commented Apr 7, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 50478f6 into kubernetes:master Apr 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 7, 2021
@liranp liranp deleted the fix-ocean-rootvolsize branch April 7, 2021 15:15
k8s-ci-robot added a commit that referenced this pull request Apr 7, 2021
…-upstream-release-1.20

Automated cherry pick of #11179: fix(spot/ocean): configure root volume size using bdm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants