Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-pull cilium and kube-proxy in warming mode #11258

Merged
merged 2 commits into from Apr 19, 2021
Merged

Pre-pull cilium and kube-proxy in warming mode #11258

merged 2 commits into from Apr 19, 2021

Conversation

olemarkus
Copy link
Member

This PR will optimise Node initialisation time by pulling kube-proxy and cilium images if we are in warming mode.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2021
johngmyers
johngmyers requested changes Apr 18, 2021
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing the warning log level is the only thing I would consider potentially blocking.

upup/pkg/fi/nodeup/nodetasks/pull_image.go Outdated Show resolved Hide resolved
upup/pkg/fi/nodeup/nodetasks/pull_image.go Outdated Show resolved Hide resolved
upup/pkg/fi/nodeup/nodetasks/pull_image.go Outdated Show resolved Hide resolved
nodeup/pkg/model/kube_proxy.go Outdated
Runtime: b.Cluster.Spec.ContainerRuntime,
}
c.AddTask(pullTask)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be simpler to wrap this up in a receiver off of NodeupModelContext. It would be even simpler still to push the ConfigurationMode test down into the task (renaming it WarmImageTask.)

@johngmyers
Copy link
Member

@olemarkus what's your take on extracting out some of the boilerplate to common code? I suspect these aren't going to be the only two images we're going to want to warm-pull.

@olemarkus
Copy link
Member Author

Something like this, perhaps?

@johngmyers
Copy link
Member

Something like that, modulo the compile error.

@olemarkus @johngmyers
Apply suggestions from code review
df4f429 
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7dc29de into kubernetes:master Apr 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olemarkus @johngmyers @k8s-ci-robot