Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure image to alpha/stable channel #11271

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Add Azure image to alpha/stable channel #11271

merged 1 commit into from
Apr 20, 2021

Conversation

kenji-cloudnatix
Copy link
Contributor

Remove the default image hard-coded in populate_instancegroup_spec.go.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @kenji-cloudnatix. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/channels labels Apr 20, 2021
@kenji-cloudnatix kenji-cloudnatix force-pushed the kenji/azure_channel branch 2 times, most recently from 7474f9f to 5874c45 Compare April 20, 2021 16:32
@hakman
Copy link
Member

hakman commented Apr 20, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2021
hakman
hakman reviewed Apr 20, 2021
View reviewed changes
channels/alpha Outdated
- name: "Canonical:UbuntuServer:20.04-LTS:latest"
providerID: azure
architectureID: amd64
kubernetesVersion: ">=1.18.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special reason for 1.18+? I would use the same version as when kOps started supporting Azure.

Suggested change
kubernetesVersion: ">=1.18.0"
kubernetesVersion: ">=1.20.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. No strong reason. Let me update this and the other channel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks. :)

@kenji-cloudnatix
Add Azure image to alpha/stable channel
221568a 
Remove the default image hard-coded in populate_instancegroup_spec.go.
hakman
hakman approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kenji-cloudnatix. Should make it easier to get started with Azure.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@kenji-cloudnatix
Copy link
Contributor Author

Great! Thanks for the quick review, @hakman !

@hakman hakman mentioned this pull request Apr 20, 2021
Merged
@k8s-ci-robot k8s-ci-robot merged commit 06ca1ff into kubernetes:master Apr 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 20, 2021
k8s-ci-robot added a commit that referenced this pull request Apr 20, 2021
@k8s-ci-robot
Merge pull request #11272 from hakman/automated-cherry-pick-of-#11271…
09f8590 
…-upstream-release-1.20

Automated cherry pick of #11271: Add Azure image to alpha/stable channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenji-cloudnatix @k8s-ci-robot @hakman