Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude nodes from load balancers upon cordoning #11273

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

johngmyers
Copy link
Member

Per kubernetes/kubernetes#90823 (k8s 1.19), nodes that are unschedulable are no longer removed from load balancers. Rolling update needs to add the appropriate label to preserve this functionality.

/area rolling-update
/kind bug

@k8s-ci-robot k8s-ci-robot added area/rolling-update kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 21, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 77a2868 into kubernetes:master Apr 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Apr 21, 2021
@johngmyers johngmyers deleted the remove-lb branch April 21, 2021 04:06
k8s-ci-robot added a commit that referenced this pull request Apr 21, 2021
…1273-upstream-release-1.19

Automated cherry pick of #11273: Exclude nodes from load balancers upon cordoning
k8s-ci-robot added a commit that referenced this pull request Apr 21, 2021
…1273-upstream-release-1.20

Automated cherry pick of #11273: Exclude nodes from load balancers upon cordoning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants