[csi/aws] Bump templates + add support for warm pools

[dntosas]

AWS EBS CSI Driver:
- Update manifests
- Bump components version
- Add API capability of setting Version + VolumeLimit
- Add support for warm pools
- Remove snapshot-controller resources as it should be independent from
any CSI driver, check here --> https://kubernetes.io/blog/2020/12/10/kubernetes-1.20-volume-snapshot-moves-to-ga/#how-to-deploy-volume-snapshots

Signed-off-by: dntosas ntosas@gmail.com

[k8s-ci-robot]

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[olemarkus]

/ok-to-test

[dntosas]

qq: where IAM resources that described in here are handled?

[olemarkus]

they are handled in pkg/model/iam/iam_builder.go.

It would be nice to collect all the privs needed for CSI to one function though, to make this more maintainable. That would also allow us to use IRSA for this addon further down the road.

[dntosas]

@olemarkus are not IAM permissions for attaching etc volumes should be present on regular nodes role also? without them how will the pods of node daemonSet can be allowed to do such operations?

[olemarkus]

As I understand it, it is the ebs-csi-controller that does the AWS calls. The purpose of the DaemonSet is to extend kubelet with the driver specific functionality.

[dntosas]

As I understand it, it is the ebs-csi-controller that does the AWS calls. The purpose of the DaemonSet is to extend kubelet with the driver specific functionality.

y makes sense ^^

[johngmyers]

I don't see the code for calculating the default value of Version

[dntosas]

@johngmyers i thought something like this should be enough ^^ if there is a more proper way or place to implement this logic, can you give a hint on where to look?

[johngmyers]

@dntosas Okay, that does work; I had missed that. Unfortunately it is error prone to have the version in so many places. If one gets missed on an update that is unlikely to be caught in code review.

The other way is to define a template function, like

kops/upup/pkg/fi/cloudup/template_functions.go

Lines 588 to 608 in dbd2347

	// AWSCCMTag returns the correct tag for the cloud controller manager based on
	// the Kubernetes Version
	func (tf *TemplateFunctions) AWSCCMTag() (string, error) {
	var tag string
	parsed, err := util.ParseKubernetesVersion(tf.Cluster.Spec.KubernetesVersion)
	if err != nil {
	return "", fmt.Errorf("failed to parse Kubernetes version from cluster spec: %q", err)
	}
	// Update when we have stable releases
	switch parsed.Minor {
	case 18:
	tag = "v1.18.0-alpha.1"
	case 19:
	tag = "v1.19.0-alpha.1"
	default:
	tag = "latest"
	}
	return tag, nil
	}

[dntosas]

@olemarkus @johngmyers thanks for your help :)

pushed changes, i think we are better now ^^

[olemarkus]

Nit: go comments should have proper punctuation.

[olemarkus]

nit: this check is typically noops as we tend to use if fi.BoolValue() which defaults to false.
And you have to use {{ if WithDefaultBool <defaultVaule> }} in templates as templates will only check if the pointer is nil or not.

[olemarkus]

Just a few nits, otherwise looks good to go to me.

[dntosas]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [olemarkus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment