Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable reading shared config when possibly from CLI #11387

Merged
merged 1 commit into from
May 23, 2021
Merged

Enable reading shared config when possibly from CLI #11387

merged 1 commit into from
May 23, 2021

Conversation

johngmyers
Copy link
Member

Remove the annoyance of having to set AWS_SDK_LOAD_CONFIG=1 when using assumed roles.

@johngmyers johngmyers added this to the v1.22 milestone May 6, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label May 6, 2021
@johngmyers johngmyers changed the title WIP Enable reading shared config when possibly from CLI Enable reading shared config when possibly from CLI May 9, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2021
@justinsb
Copy link
Member

This is a good idea, though I don't think we should backport it so we have time to vet it ourselves.

Can you also send a PR for the 1.22 release notes? (It's an enhancement, but people should be made aware of it in case they are surprised)

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3a376e9 into kubernetes:master May 23, 2021
@johngmyers johngmyers deleted the aws-config branch May 23, 2021 22:19
@johngmyers johngmyers mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @justinsb @k8s-ci-robot