Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport rename of service-account key to 1.20 #11388

Merged
merged 2 commits into from
May 9, 2021

Conversation

johngmyers
Copy link
Member

Addresses #11370

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone May 6, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2021
@k8s-ci-robot k8s-ci-robot added area/nodeup size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2021
@justinsb
Copy link
Member

justinsb commented May 7, 2021

Like #11390, this looks good, but I propose we get an upgrade e2e periodic test in asap

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
@hakman
Copy link
Member

hakman commented May 7, 2021

@justinsb should be covered by @rifelpet's new upgrade test:
https://testgrid.k8s.io/kops-misc#kops-aws-kops-upgrade

I see this in logs, which I am not sure if it's the expected change:

  Keypair/service-account
  	Signer              	 id:cn=service-account -> <nil>
  	LegacyFormat        	 true -> false

@johngmyers johngmyers changed the title WIP Backport rename of service-account key to 1.20 Backport rename of service-account key to 1.20 May 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2021
@johngmyers
Copy link
Member Author

@hakman The LegacyFormat change is saying that it will upgrade the format (by copying it from the "master" slot to "service-account". For the "Signer" field, nil means "self-signed" so it is not an actual change.

@johngmyers
Copy link
Member Author

For an upgrade from 1.18 or earlier, the signer would change from "ca" to being self-signed.

@justinsb
Copy link
Member

justinsb commented May 9, 2021

Reproducing #11390 is non-trivial (which is a good thing, as it means this isn't as critical as it first appears)!

/hold cancel

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5a9a912 into kubernetes:release-1.20 May 9, 2021
@johngmyers johngmyers deleted the sa-backport-1.20 branch May 9, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants