Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code for no-longer-supported k8s versions #11412

Merged
merged 2 commits into from
May 8, 2021
Merged

Remove code for no-longer-supported k8s versions #11412

merged 2 commits into from
May 8, 2021

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 8, 2021
@johngmyers johngmyers force-pushed the remove-unsupported branch 2 times, most recently from d3ede37 to a44f5fb Compare May 8, 2021 04:34
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2021
@hakman
Copy link
Member

hakman commented May 8, 2021

/retest

1 similar comment
@johngmyers
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2021
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 8, 2021
@hakman
Copy link
Member

hakman commented May 8, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1761076 into kubernetes:master May 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone May 8, 2021
@johngmyers johngmyers deleted the remove-unsupported branch May 8, 2021 15:55
@johngmyers johngmyers removed this from the v1.21 milestone May 10, 2021
@johngmyers johngmyers added this to the v1.22 milestone May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@hakman hakman hakman approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@olemarkus olemarkus

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johngmyers @hakman @k8s-ci-robot @olemarkus