Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new clusters without forcing a container runtime #11428

Merged
merged 1 commit into from
May 9, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented May 9, 2021

Decide which container runtime to use later in model, based on Kubernetes version and other settings.

Fixes: #11402

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 9, 2021
@johngmyers
Copy link
Member

Need to regenerate CLI docs.

Decide which container runtime to use later in model, based on Kubernetes version and other settings.
@hakman hakman force-pushed the container-runtime_default branch from a3f2966 to 54961e4 Compare May 9, 2021 18:44
@k8s-ci-robot k8s-ci-robot added area/documentation and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 9, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johngmyers,rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added a commit that referenced this pull request May 9, 2021
…-upstream-release-1.21

Automated cherry pick of #11428: Create new clusters without forcing a container runtime
@k8s-ci-robot k8s-ci-robot merged commit 0e1a65b into kubernetes:master May 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone May 9, 2021
k8s-ci-robot added a commit that referenced this pull request May 9, 2021
…-upstream-release-1.20

Automated cherry pick of #11428: Create new clusters without forcing a container runtime
@johngmyers johngmyers modified the milestones: v1.21, v1.22 May 10, 2021
@hakman hakman deleted the container-runtime_default branch May 12, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

containerd is forced to be used for all k8s versions by default
4 participants