-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upup: gcetasks: force send AutoCreateSubnetworks field when set to false #11457
Conversation
When a struct contains a default value, it is not present in the serialized output attached to request bodies sent to GCP. In the case that a user wishes to explicitly set the `AutoCreateSubnetworks` field to `false`, the request sent to GCP does not contain this directive, and the network is provisioned with the default of `true`. Explicitly specify that the `false` value should be present on the request sent to the GCP API, making use of the `ForceSendFields` field in the requset struct. Signed-off-by: Nick Travers <n.e.travers@gmail.com>
Welcome @nicktrav! |
Hi @nicktrav. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @rifelpet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow :). Thanks for the fix!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.21 Automated cherry pick of #11457: upup: gcetasks: force send AutoCreateSubnetworks field when
…-upstream-release-1.20 Automated cherry pick of #11457: upup: gcetasks: force send AutoCreateSubnetworks field when
When a struct contains a default value, it is not present in the
serialized output attached to request bodies sent to GCP. In the case
that a user wishes to explicitly set the
AutoCreateSubnetworks
fieldto
false
, the request sent to GCP does not contain this directive, andthe network is provisioned with the default of
true
.Explicitly specify that the
false
value should be present on therequest sent to the GCP API, making use of the
ForceSendFields
fieldin the requset struct.
Signed-off-by: Nick Travers n.e.travers@gmail.com