Update CAS manifest #11491
Update CAS manifest #11491
Conversation
k8s-ci-robot
added
cncf-cla: yes
upup/models/cloudup/resources/addons/cluster-autoscaler.addons.k8s.io/k8s-1.15.yaml.template
Outdated
Show resolved
Hide resolved
olemarkus
force-pushed
the
cas-update-manifest
branch
from
02b1623
to
3872253
Compare
| operator: In | ||
| values: | ||
| - cluster-autoscaler | ||
| topologyKey: kubernetes.io/hostname |
There was a problem hiding this comment.
As mentioned elsewhere, would like an additional soft anti-affinity to zone, to handle the 5 nodes in 3 zones case.
There was a problem hiding this comment.
I think we could change topologyKey to topology.kuberenetes.io/zone. It wouldn't cover if someone puts all 3 CP nodes in the same zone. But I wonder ControlPlaneControllerReplicas should then return 1.
There was a problem hiding this comment.
It still makes sense to have 2 replicas in a single-zone multi-control-plane-node cluster.
k8s-ci-robot
added
the
needs-rebase
Upstream examples were missing a number of improvements. This commit also adds template functions for making controllers such as CAS more HA on HA clusters
olemarkus
force-pushed
the
cas-update-manifest
branch
from
3872253
to
2fb1861
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…491-origin-release-1.21 Automated cherry pick of #11491: Update CAS manifest
Upstream examples were missing a number of improvements.
This commit also adds template functions for making controllers such as CAS more HA on HA clusters