Add support for arbitrary terraform functions #11542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows terraformWriter.LiteralFunctionExpression to be used with any terraform function. The arguments must be strings, which means that any string arguments must include quotes.
k8s-ci-robot
added
do-not-merge/hold
|
The thing that concerns me is lack of quoting |
|
Other than that, looks good. I don't consider that blocking. |
k8s-ci-robot
added
the
lgtm
|
Same here. |
|
We can improve escaping in a followup. The HCL library may be able to help us there /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
terraformWriter.LiteralFunctionExpressionto be used with any terraform function.The arguments must be strings, which means that any string arguments must include quotes. I was debating between this and using a slice of interfaces for
Literal.FnArgsand passing each tojson.Marshalto get their string representations (which would quote the strings for us). This would require either returning thejson.Marshalerror up through all of the HCL2 rendering (which doesn't currently return errors) or adding a panic which I'm not excited about.Feedback welcome.
/hold