Add snapshot-controller #11561
Merged
Add snapshot-controller #11561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
olemarkus
force-pushed
the
actually-add-snapshot-controller
branch
from
f496123
to
f1c9edb
Compare
k8s-ci-robot
added
size/XL
olemarkus
force-pushed
the
actually-add-snapshot-controller
branch
from
f1c9edb
to
1868313
Compare
hakman
approved these changes
May 22, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
May 22, 2021
…561-origin-release-1.21 Automated cherry pick of #11561: Add snapshot-controller
rifelpet
reviewed
May 22, 2021
| "ec2:DescribeAvailabilityZones", | ||
| "ec2:DescribeSnapshots", | ||
| ), | ||
| Resource: stringorslice.Slice([]string{"*"}), |
There was a problem hiding this comment.
Can we restrict this any further for ec2:DeleteSnapshot ? It seems pretty broad as-is.
There was a problem hiding this comment.
Yeah. This one got lost as well. I'll fix this shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow this got left out of the preview PR ...