Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow deletion of snapshots owned by the cluster #11571

Merged
merged 1 commit into from
May 23, 2021
Merged

Only allow deletion of snapshots owned by the cluster #11571

merged 1 commit into from
May 23, 2021

Conversation

olemarkus
Copy link
Member

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 23, 2021
@hakman
Copy link
Member

hakman commented May 23, 2021

/retest

rifelpet
rifelpet reviewed May 23, 2021
View reviewed changes
Copy link
Member

@rifelpet rifelpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does snapshot controller include this tag by default? I don't see the cluster name being passed in to the controller's args.

Or is the snapshot's tags copied from the volume?

@olemarkus
Copy link
Member Author

The way snapshoting works is a bit involved. It is the CSI driver that does the actual snapshoting. The controller just watches CRDs and calls the api.

Also, when I ran e2e tests, they pass. So I assume everything is tagged appropriately.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5e720e9 into kubernetes:master May 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 23, 2021
@olemarkus olemarkus mentioned this pull request May 23, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request May 23, 2021
@k8s-ci-robot
Merge pull request #11580 from olemarkus/automated-cherry-pick-of-#11…
4a9e91c 
…571-origin-release-1.21

Automated cherry pick of #11571: Only allow deletion of snapshots owned by the cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olemarkus @hakman @k8s-ci-robot @rifelpet