Improve some small issues with the release process #11572
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -183,6 +185,7 @@ k8s-container-image-promoter --thin-manifest-dir k8s.gcr.io | |||
| Currently we send the image and non-image artifact promotion PRs separately. | |||
|
|
|||
| ``` | |||
| cd ${GOPATH}/src/k8s.io/k8s.io | |||
There was a problem hiding this comment.
| cd ${GOPATH}/src/k8s.io/k8s.io | |
| cd ${GOPATH}/src/k8s.io/k8s.io | |
| git checkout main | |
| git pull |
There was a problem hiding this comment.
Already done in "Create container promotion PR" step.
There was a problem hiding this comment.
But they why do you add a cd? It would make sense to either assume the same context of the previous step or to reestablish it from scratch, but not to reestablish only part of the context.
There was a problem hiding this comment.
Makes sense when you skip previous step.
There was a problem hiding this comment.
But if you skip the previous step you might not be on the head of master.
There was a problem hiding this comment.
Previous step as in "You can dry-run the promotion...".
hakman
force-pushed
the
release-proces_nits
branch
from
872e163
to
ab278d0
Compare
hakman
force-pushed
the
release-proces_nits
branch
from
ab278d0
to
49cb740
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
/cc @johngmyers