Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for logging-format option (text/json) #11583

Merged
merged 1 commit into from Jun 21, 2021
Merged

Add support for logging-format option (text/json) #11583

merged 1 commit into from Jun 21, 2021

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented May 23, 2021 •
edited by hakman

Fixes: #11576

Signed-off-by: dntosas ntosas@gmail.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2021
@dntosas dntosas changed the title WIP - Add support for logging-format option (text/json) Add support for logging-format option (text/json) May 23, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2021
johngmyers
johngmyers requested changes May 23, 2021
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/apis/kops/componentconfig.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2021
@dntosas dntosas force-pushed the json-logging branch 2 times, most recently from 2fcc05c to e4bf127 Compare June 3, 2021 20:52
@dntosas dntosas requested a review from johngmyers June 3, 2021 20:56
johngmyers
johngmyers reviewed Jun 4, 2021
View reviewed changes
pkg/apis/kops/componentconfig.go Outdated
Comment on lines 48 to 50
// LogFormat is the logging format of the kubelet. (text/json)
// Default: text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// LogFormat is the logging format of the kubelet. (text/json)
// Default: text
// LogFormat is the logging format of the kubelet.
// Supported values: text, json.
// Default: text

@dntosas
Add support for logging-format option (text/json)
43dc375 
Signed-off-by: dntosas <ntosas@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/documentation and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4df9da0 into kubernetes:master Jun 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 21, 2021
@dntosas dntosas mentioned this pull request Oct 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Support structured logging ('--logging-format=json')
3 participants
@dntosas @k8s-ci-robot @johngmyers