Spotinst: Support for API Load Balancer with AWS/NLB #11604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/api
area/provider/aws
rifelpet
requested changes
Jun 9, 2021
Comment on lines
+679
to
+680
| group.Compute.LaunchSpecification.LoadBalancersConfig.LoadBalancers = | ||
| append(group.Compute.LaunchSpecification.LoadBalancersConfig.LoadBalancers, tgs...) |
There was a problem hiding this comment.
Suggested change
| group.Compute.LaunchSpecification.LoadBalancersConfig.LoadBalancers = | |
| append(group.Compute.LaunchSpecification.LoadBalancersConfig.LoadBalancers, tgs...) | |
| group.Compute.LaunchSpecification.LoadBalancersConfig.TargetGroups = | |
| append(group.Compute.LaunchSpecification.LoadBalancersConfig.TargetGroups, tgs...) |
There was a problem hiding this comment.
Hi @rifelpet. Thanks for reviewing this! Please note that there is no TargetGroups field in the LoadBalancersConfig object. It only takes a list of LoadBalancer objects, and each of them defines the type of load balancer in its Type field.
Comment on lines
+1194
to
+1195
| group.Compute.LaunchSpecification.LoadBalancersConfig.LoadBalancers = | ||
| append(group.Compute.LaunchSpecification.LoadBalancersConfig.LoadBalancers, tgs...) |
There was a problem hiding this comment.
Suggested change
| group.Compute.LaunchSpecification.LoadBalancersConfig.LoadBalancers = | |
| append(group.Compute.LaunchSpecification.LoadBalancersConfig.LoadBalancers, tgs...) | |
| group.Compute.LaunchSpecification.LoadBalancersConfig.TargetGroups = | |
| append(group.Compute.LaunchSpecification.LoadBalancersConfig.TargetGroups, tgs...) |
rifelpet
approved these changes
Jun 10, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thank you, @rifelpet. I really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements #9011 by adding support for API Load Balancer with AWS/NLB for the Spotinst provider.