Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set lifecycle on WarmPool task #11618

Merged
merged 1 commit into from
May 30, 2021
Merged

Set lifecycle on WarmPool task #11618

merged 1 commit into from
May 30, 2021

Conversation

johngmyers
Copy link
Member

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 28, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label May 28, 2021
@johngmyers johngmyers force-pushed the warmpool-lifecycle branch 2 times, most recently from ca976aa to 8011700 Compare May 29, 2021 03:05
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 10cc439 into kubernetes:master May 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 30, 2021
@johngmyers johngmyers deleted the warmpool-lifecycle branch May 30, 2021 18:36
@johngmyers johngmyers mentioned this pull request May 30, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request May 31, 2021
@k8s-ci-robot
Merge pull request #11632 from johngmyers/automated-cherry-pick-of-#1…
221eb0f 
…1618-upstream-release-1.21

Automated cherry pick of #11618: Set lifecycle on WarmPool task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @k8s-ci-robot @olemarkus