-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the service account issuer discovery documentation #11642
Conversation
Have we verified Istio sets the API audience correctly? |
Only kOps documentation on istio says anything about setting audience directly on the api server. It would also be very hard to achieve this on say managed kubernetes. |
Istio documentation also mentions setting the API audience. They seem to have copied from us. |
That's the docs I referred to that was kops specific (and now incorrect). The linked issue also suggested that this worked without setting audience. Could ask there to confirm audience is really not set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw the confirmation in the linked issue.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Filed istio/istio.io#9859 |
Fixes #11623