Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the service account issuer discovery documentation #11642

Merged
merged 1 commit into from
May 31, 2021

Conversation

olemarkus
Copy link
Member

Fixes #11623

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2021
@johngmyers
Copy link
Member

Have we verified Istio sets the API audience correctly?

@olemarkus
Copy link
Member Author

Only kOps documentation on istio says anything about setting audience directly on the api server. It would also be very hard to achieve this on say managed kubernetes.

@johngmyers
Copy link
Member

Istio documentation also mentions setting the API audience. They seem to have copied from us.

@olemarkus
Copy link
Member Author

That's the docs I referred to that was kops specific (and now incorrect). The linked issue also suggested that this worked without setting audience. Could ask there to confirm audience is really not set.

Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw the confirmation in the linked issue.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit ef43708 into kubernetes:master May 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 31, 2021
@johngmyers
Copy link
Member

Filed istio/istio.io#9859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create cluster due to oservice-account-jwks-uri setting
3 participants