Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate CSI livenessprobe images for multi-arch support #11652

Merged
merged 1 commit into from
May 31, 2021

Conversation

rifelpet
Copy link
Member

This manifest includes two liveness-probe containers but they use different images.
The k8s.gcr.io image is multi-arch but the quay.io image is not.
By only using the k8s.gcr.io one we should fix arm64 clusters now that EBS CSI is enabled by default.

ref: https://testgrid.k8s.io/kops-misc#kops-aws-misc-arm64-ci&show-stale-tests=

https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-aws-misc-arm64-ci/1397862870238105600/artifacts/cluster-info/kube-system/ebs-csi-node-g2wjb/logs.txt

==== START logs for container liveness-probe of pod kube-system/ebs-csi-node-g2wjb ====
standard_init_linux.go:219: exec user process caused: exec format error
==== END logs for container liveness-probe of pod kube-system/ebs-csi-node-g2wjb ====

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2021
This manifest includes two liveness-probe containers but they use different images.
The k8s.gcr.io image is multi-arch but the quay.io image is not.
By only using the k8s.gcr.io one we should fix arm64 clusters now that EBS CSI is enabled by default.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2021
@rifelpet
Copy link
Member Author

for reference, the quay image is not referenced anywhere upstream: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/search?q=livenessprobe

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit b3bd622 into kubernetes:master May 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 31, 2021
k8s-ci-robot added a commit that referenced this pull request Jun 1, 2021
…52-origin-release-1.21

Automated cherry pick of #11652: Consolidate CSI livenessprobe images for multi-arch support
k8s-ci-robot added a commit that referenced this pull request Jun 1, 2021
…52-origin-release-1.20

Automated cherry pick of #11652: Consolidate CSI livenessprobe images for multi-arch support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants