Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move common stuff in e2e scenarios to common.sh #11668

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Move common stuff in e2e scenarios to common.sh #11668

merged 1 commit into from
Jun 2, 2021

Conversation

olemarkus
Copy link
Member

No description provided.

@olemarkus olemarkus requested a review from rifelpet June 2, 2021 06:44
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2021
rifelpet
rifelpet reviewed Jun 2, 2021
View reviewed changes
tests/e2e/scenarios/lib/common.sh Outdated Show resolved Hide resolved
tests/e2e/scenarios/lib/common.sh Show resolved Hide resolved
tests/e2e/scenarios/lib/common.sh
}
trap kops-finish EXIT

make test-e2e-install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should wrap this in a pushd/popd to ensure its ran from the repo root?

@olemarkus olemarkus marked this pull request as ready for review June 2, 2021 17:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2021
@olemarkus
Copy link
Member Author

I think this is a step in the right direction. Probably one can wrap the kubetest2 commands in a common function as well. They now seem to mostly take the same arguments (overrides, CNI and zones differ). But that is more for a follow up.

@olemarkus
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5386b4b into kubernetes:master Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 2, 2021
@rifelpet rifelpet mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olemarkus @k8s-ci-robot @rifelpet