Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit concurrency of asset copy tasks #11708

Merged
merged 5 commits into from
Jun 22, 2021
Merged

Limit concurrency of asset copy tasks #11708

merged 5 commits into from
Jun 22, 2021

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jun 7, 2021 •
edited by hakman
Loading

Why: parallelism after a certain point doesn't make things any faster: there's only so much bandwidth. Less parallelism increases the amount of feedback on progress and allows retries of interrupted copies to better avoid recopying by having more completed copies.

How: It uses a buffered channel as a semaphore.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 7, 2021
@johngmyers
Copy link
Member Author

/cc @hakman @rifelpet

@hakman
Copy link
Member

hakman commented Jun 18, 2021

This would deserve a description with why and how it's done. Other than that...
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2021
@johngmyers
Copy link
Member Author

Why: parallelism after a certain point doesn't make things any faster: there's only so much bandwidth. Less parallelism increases the amount of feedback on progress and allows retries of interrupted copies to better avoid recopying by having more completed copies.

How: It uses a buffered channel as a semaphore.

@johngmyers
Copy link
Member Author

@hakman Is there a particular place you wanted that description? How can I move this forward?

hakman
hakman approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed this.
Description was not for me but for anyone looking at this 6 months from now.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 364fe4c into kubernetes:master Jun 22, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 22, 2021
@johngmyers johngmyers deleted the refactor-assets branch June 22, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @hakman @k8s-ci-robot