Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy envs to calico to make possible usage of AWS source destination check #11709

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Add proxy envs to calico to make possible usage of AWS source destination check #11709

merged 1 commit into from
Jun 7, 2021

Conversation

DOboznyi
Copy link
Contributor

@DOboznyi DOboznyi commented Jun 7, 2021

After 1.19 update calico was also updated and source-destination check was included in calico natively. So when you're using proxy and cluster created it can't be validated without manual patch:

kubectl set env daemonset/calico-node -n kube-system http_proxy=http://<proxy_url>:<proxy_port>
kubectl set env daemonset/calico-node -n kube-system https_proxy=http://<proxy_url>:<proxy_port>
kubectl set env daemonset/calico-node -n kube-system no_proxy=<no_proxy_list>

Signed-off-by: Dmytro Oboznyi dmytro.oboznyi@syncier.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @DOboznyi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2021
@hakman
Copy link
Member

hakman commented Jun 7, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2021
@hakman
Copy link
Member

hakman commented Jun 7, 2021

Please also squash the commits. It should be good to merge otherwise.

…tion check

Signed-off-by: Dmytro Oboznyi <dmytro.oboznyi@syncier.com>
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 038d908 into kubernetes:master Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 7, 2021
k8s-ci-robot added a commit that referenced this pull request Jun 7, 2021
…-upstream-release-1.21

Automated cherry pick of #11709: Add proxy envs to calico to make possible usage of AWS source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants