Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate AWSEBSCSIDriver model only when using AWS #11716

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Generate AWSEBSCSIDriver model only when using AWS #11716

merged 1 commit into from
Jun 8, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 8, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2021
@hakman hakman mentioned this pull request Jun 8, 2021
Merged
@johngmyers
Copy link
Member

There's more refinement to do here.

validateSnapshotController() requires AWSEBSCSIDriver be enabled even when not using the AWS cloud provider.

Either AWSEBSCSIDriverBuilder.Build() should do nothing for non-AWS cloud providers or API validation should validate the cloud provider is AWS when enabling AWSEBSCSIDriver. Same for KubeControllerManagerOptionsBuilder and KubeletOptionsBuilder

@hakman
Copy link
Member Author

hakman commented Jun 8, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 424ed25 into kubernetes:master Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 8, 2021
k8s-ci-robot added a commit that referenced this pull request Jun 8, 2021
@k8s-ci-robot
Merge pull request #11718 from hakman/automated-cherry-pick-of-#11716…
7a5e0ff 
…-upstream-release-1.21

Automated cherry pick of #11716: Generate AWSEBSCSIDriver model only when using AWS
@hakman hakman deleted the awsebscsi_driver branch October 22, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakman @k8s-ci-robot @johngmyers