Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quay images for cilium #11722

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

olemarkus
Copy link
Member

a) again I got a request for this over docker rate limiting
b) Since with containerd, docker credentials are not valid for image pulls outside of kubelet, docker.io images will hit rate limiting
c) upstream use quay by default

cilium with hubble already has a dependency on cert-manager, which is hosted on quay so quay is to some extent a dependency anyway.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added area/nodeup size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 8, 2021
@olemarkus olemarkus requested a review from johngmyers June 8, 2021 21:09
@hakman
Copy link
Member

hakman commented Jun 9, 2021

@olemarkus Any thoughts about doing this the same way we do for Calico?
372fde0

@olemarkus
Copy link
Member Author

Was considered and decided against: #10204

@hakman
Copy link
Member

hakman commented Jun 9, 2021

Was considered and decided against: #10204

I guess we can revisit that. The decision was in the context of us doing an API change soon.
Generic string replace in image urls could be a solution, but I don't see anyone interested in doing that.
Docker to Quay will generate the same amount of requests the other way around when Quay goes down.

@johngmyers
Copy link
Member

Upstream default is a powerful argument.

For kOps 1.22, local image registries will be a lot easier to manage.

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@hakman
Copy link
Member

hakman commented Jun 9, 2021

Upstream default is a powerful argument.

I agree.

For kOps 1.22, local image registries will be a lot easier to manage.

Still harder than setting the image version or registry.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0d63479 into kubernetes:master Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 9, 2021
k8s-ci-robot added a commit that referenced this pull request Jun 9, 2021
…722-origin-release-1.21

Automated cherry pick of #11722: Use quay images for cilium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants