-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set BindAddress appropriately when in IPv6-only mode #11737
Conversation
@@ -129,7 +129,11 @@ func (b *KubeAPIServerOptionsBuilder) BuildOptions(o interface{}) error { | |||
c.LogLevel = 2 | |||
c.SecurePort = 443 | |||
|
|||
c.BindAddress = "0.0.0.0" | |||
if clusterSpec.IsIPv6Only() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts about using IsIPv6CIDR
?
if clusterSpec.IsIPv6Only() { | |
if cidr.IsIPv6CIDR(clusterSpec.NonMasqueradeCIDR) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that we are testing NonMasqueradeCIDR
is not knowledge that should be spread all over the codebase. It should be centralized in one place.
b0068b4
to
fc9ec13
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.