Allow unsetting fields from the command line #11745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
johngmyers
force-pushed
the
remove-option
branch
from
be47aec
to
bbf3075
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
hakman
reviewed
Jun 14, 2021
| @@ -70,8 +70,10 @@ type CreateClusterOptions struct { | |||
| // SSHPublicKeys is a map of the SSH public keys we should configure; required on AWS, not required on GCE | |||
| SSHPublicKeys map[string][]byte | |||
|
|
|||
| // Overrides allows settings values direct in the spec | |||
| // Overrides allows setting values directly in the spec. | |||
| Overrides []string | |||
There was a problem hiding this comment.
Maybe we can rename 'Overrides' to Sets to be consistent.
/hold in case you want to do that
/lgtm
/approve
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I will do the rename in a followup PR. |
k8s-ci-robot
removed
the
do-not-merge/hold
johngmyers
force-pushed
the
remove-option
branch
from
bbf3075
to
76fc012
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.