Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the NodeCIDRMaskSize appropriately for IPv6 #11762

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 15, 2021
@johngmyers
Copy link
Member Author

/cc @hakman @rifelpet

@hakman
Copy link
Member

hakman commented Jun 15, 2021

What would be the reason to default to more than /120 -> 2^8=256 or maybe 118 -> 2^10=1024 pods per node?
k8s recommendation is 110 pods per node: https://kubernetes.io/docs/setup/best-practices/cluster-large/.

@johngmyers
Copy link
Member Author

Well, the NodeCIDRMaskSize can't be more than 16 bits larger than the ClusterCIDR prefix, so if we limit the NodeCIDRMaskSize to a minimum of 118 we'd have to limit the ClusterCIDR to a /102.

Aesthetically, it makes sense to split things on the colon boundaries. So that would mean a PodCIDR of /96 and a NodeCIDRMaskSize of 112. But that would be a different PR adjusting the default PodCIDR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5300e58 into kubernetes:master Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 15, 2021
@johngmyers johngmyers deleted the ipv6-mask branch June 15, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants