Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the AdminAccess default inclusive of IPv6 #11763

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Make the AdminAccess default inclusive of IPv6 #11763

merged 2 commits into from
Jun 15, 2021

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jun 15, 2021 •
edited
Loading

The previous behavior did not match the documentation.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added area/documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2021
@johngmyers
Copy link
Member Author

/retest

@hakman
Copy link
Member

hakman commented Jun 15, 2021

Related Q, any thoughts about NLB/CLB defaulting to dual-stack?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4cd3b58 into kubernetes:master Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 15, 2021
@johngmyers
Copy link
Member Author

Kubernetes documents loadBalancerSourceRanges as defaulting to 0.0.0.0/0. It would probably take a KEP to change that. And that might not fly due to the possibility of a workload choking on an IPv6 address in the PROXY protocol or whatever.

@johngmyers johngmyers deleted the ipv6-access branch June 15, 2021 06:31
@johngmyers
Copy link
Member Author

The LB for the API server we should be dual-stack if APIAccess has both IPv4 and IPv6.

@hakman
Copy link
Member

hakman commented Jun 15, 2021

Is there any reason not to default to dual-stack? IPv4 / IPv6 access could be controlled only by firewall rules.

@johngmyers
Copy link
Member Author

I can't think of any reason not to have this be controlled only by firewall rules.

@ching-kuo ching-kuo mentioned this pull request Dec 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @hakman @k8s-ci-robot