Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also set haveUserInfo=true in case --user was provided in "kops export kubecfg" #11778

Merged
merged 1 commit into from Jun 17, 2021
Merged

Also set haveUserInfo=true in case --user was provided in "kops export kubecfg" #11778

merged 1 commit into from Jun 17, 2021

Conversation

codablock
Copy link
Contributor

Without setting it to true, --user is completely ignored.

@codablock
Also set haveUserInfo=true in case --user was provided in "kops expor…
6ae8d8c 
…t kubecfg"

Without setting it to true, --user is completely ignored.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @codablock. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2021
@codablock
Copy link
Contributor Author

I assume this must be cherry-picked into the next 1.21 beta and also into 1.20

@olemarkus
Copy link
Member

@yurrriq is this the same issue you mentioned?

@olemarkus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
@yurrriq
Copy link
Contributor

yurrriq commented Jun 16, 2021

@yurrriq is this the same issue you mentioned?

Seems related at least.

@olemarkus
Copy link
Member

@yurrriq is this the same issue you mentioned?

Seems related at least.

Are you able to test this patch and see if it works for you as well?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2021
@codablock
Copy link
Contributor Author

/retest

1 similar comment
@johngmyers
Copy link
Member

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 190531f into kubernetes:master Jun 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 17, 2021
@codablock codablock deleted the fix-kops-export branch June 17, 2021 07:11
This was referenced Jun 19, 2021
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 19, 2021
@k8s-ci-robot
Merge pull request #11812 from olemarkus/automated-cherry-pick-of-#11…
8a93058 
…778-origin-release-1.21

Automated cherry pick of #11778: Also set haveUserInfo=true in case --user was provided in
k8s-ci-robot added a commit that referenced this pull request Jun 19, 2021
@k8s-ci-robot
Merge pull request #11813 from olemarkus/automated-cherry-pick-of-#11…
5be5dcc 
…778-origin-release-1.20

Automated cherry pick of #11778: Also set haveUserInfo=true in case --user was provided in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@hakman hakman Awaiting requested review from hakman

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@codablock @k8s-ci-robot @olemarkus @yurrriq @johngmyers @fejta-bot