Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validating presence of AWS EBS CSI #11795

Merged
merged 2 commits into from
Jun 20, 2021
Merged

Fix validating presence of AWS EBS CSI #11795

merged 2 commits into from
Jun 20, 2021

Conversation

olemarkus
Copy link
Member

As of k8s 1.22, EBS driver is always installed. This PR makes validation pass when not explicitly enabling EBS CSI Driver.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2021
@olemarkus olemarkus requested a review from rifelpet June 17, 2021 18:50
@johngmyers
Copy link
Member

Shouldn't that validation do a k8s version check?

@olemarkus
Copy link
Member Author

Version check was missing before as well. But added now.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 20, 2021
@olemarkus
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2021
@hakman
Copy link
Member

hakman commented Jun 20, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2021
@hakman
Copy link
Member

hakman commented Jun 20, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit a5d0cdf into kubernetes:master Jun 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 20, 2021
@johngmyers johngmyers mentioned this pull request Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@rifelpet rifelpet Awaiting requested review from rifelpet

@johngmyers johngmyers Awaiting requested review from johngmyers

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olemarkus @johngmyers @k8s-ci-robot @hakman