-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include multiple cluster CAs in trust stores #11809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jun 19, 2021
k8s-ci-robot
added
area/documentation
area/kops-controller
area/nodeup
area/provider/openstack
Issues or PRs related to openstack provider
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Jun 19, 2021
johngmyers
force-pushed
the
rotate-5
branch
2 times, most recently
from
June 19, 2021 07:19
3a9752d
to
d897f11
Compare
johngmyers
changed the title
WIP More cluster CA rotation refactoring
Include multiple cluster CAs in trust stores
Jun 19, 2021
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jun 19, 2021
/assign @olemarkus |
olemarkus
approved these changes
Jun 20, 2021
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 20, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/api
area/documentation
area/kops-controller
area/nodeup
area/provider/openstack
Issues or PRs related to openstack provider
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things:
nodeup.Config
.FindPrimaryKeypair
interface.BuildCertificatePairTask
used by kops-controller use consistent file naming and prepare it to subsumeBuildCertificateTask
andBuildPrivateKeyTask
.CAStore
interface.