Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include multiple cluster CAs in trust stores #11809

Merged
merged 9 commits into from
Jun 20, 2021

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jun 19, 2021

This does a few things:

  • Puts the cluster CA trust store into nodeup.Config.
    • Staging new CAs will cause rolling update to replace all nodes.
    • Worker nodes eventually won't need read access to the cert store.
  • Includes all cluster CA certs in the trust stores for most components.
    • AWS IAM Authenticator is yet to be converted.
  • Starts refactoring users of private keys to the new keypair-based interfaces.
    • Bootstrap kubeconfig generation code to use the new FindPrimaryKeypair interface.
    • Make the BuildCertificatePairTask used by kops-controller use consistent file naming and prepare it to subsume BuildCertificateTask and BuildPrivateKeyTask.
  • Removes some unused methods in the CAStore interface.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2021
@k8s-ci-robot k8s-ci-robot added area/documentation area/kops-controller area/nodeup area/provider/openstack Issues or PRs related to openstack provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2021
@johngmyers johngmyers force-pushed the rotate-5 branch 2 times, most recently from 3a9752d to d897f11 Compare June 19, 2021 07:19
@johngmyers johngmyers changed the title WIP More cluster CA rotation refactoring Include multiple cluster CAs in trust stores Jun 19, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2021
@johngmyers
Copy link
Member Author

/assign @olemarkus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit e4eff07 into kubernetes:master Jun 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 20, 2021
@johngmyers johngmyers deleted the rotate-5 branch June 20, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/kops-controller area/nodeup area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants