Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable IRSA for CCM #11818

Merged
merged 3 commits into from
Aug 7, 2021
Merged

Enable IRSA for CCM #11818

merged 3 commits into from
Aug 7, 2021

Conversation

olemarkus
Copy link
Member

This also vastly reduces what the master profile is allowed to when IRSA is enabled.
Mostly s3 stuff remaining. There is also some DNS stuff that maybe should be moved to dns-controller in a follow-up.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 19, 2021
@olemarkus olemarkus force-pushed the irsa-ccm branch 2 times, most recently from 651c128 to aaae4a4 Compare June 20, 2021 18:30
@olemarkus olemarkus changed the title WIP: Enable IRSA for CCM Enable IRSA for CCM Jun 20, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager-irsa
/test pull-kops-e2e-aws-cloud-controller-manager

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager-irsa
/test pull-kops-e2e-aws-cloud-controller-manager

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager-irsa
/test pull-kops-e2e-aws-cloud-controller-manager

1 similar comment
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager-irsa
/test pull-kops-e2e-aws-cloud-controller-manager

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager-irsa
/test pull-kops-e2e-aws-cloud-controller-manager

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-ebs-csi-driver

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2021
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager-irsa
/test pull-kops-e2e-aws-cloud-controller-manager

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2021
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager-irsa

@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager-irsa

@olemarkus
Copy link
Member Author

/retest

2 similar comments
@olemarkus
Copy link
Member Author

/retest

@olemarkus
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2021
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager

1 similar comment
@olemarkus
Copy link
Member Author

/test pull-kops-e2e-aws-cloud-controller-manager

Ole Markus With and others added 2 commits August 7, 2021 10:27
@johngmyers
IRSA support for CCM
ce86d85 
Update pkg/model/components/addonmanifests/awscloudcontroller/iam.go

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
Add ccm integration tests
8874399
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 7, 2021 •
edited
Loading

@olemarkus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-kops-e2e-aws-cloud-controller-manager-irsa 0a82bb7 link /test pull-kops-e2e-aws-cloud-controller-manager-irsa
pull-kops-e2e-aws-cloud-controller-manager d3ba783 link /test pull-kops-e2e-aws-cloud-controller-manager

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@olemarkus
Copy link
Member Author

/retest

@olemarkus olemarkus changed the title WIP: Enable IRSA for CCM Enable IRSA for CCM Aug 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 82e4e5a into kubernetes:master Aug 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

@hakman hakman Awaiting requested review from hakman

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olemarkus @johngmyers @k8s-ci-robot @hakman