Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew: remove kops.rb #11819

Merged
merged 1 commit into from
Jun 19, 2021
Merged

brew: remove kops.rb #11819

merged 1 commit into from
Jun 19, 2021

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jun 19, 2021

Right now the kops formula is well maintained in the homebrew-core side,
see the past PRs and the latest one.

Thus removing the kops.rb formula file in favor of
the homebrew-core one.

Right now the kops formula is well maintained in the homebrew-core side,
see [the past PRs](https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+kops+) and [the latest one](Homebrew/homebrew-core#79634).

Thus removing the kops.rb formula file in favor of
[the homebrew-core one](https://github.com/Homebrew/homebrew-core/blob/master/Formula/kops.rb).

Signed-off-by: Rui Chen <rui@chenrui.dev>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit eb87987 into kubernetes:master Jun 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 19, 2021
@chenrui333 chenrui333 deleted the remove-kops.rb branch June 20, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants